-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix post octal bugs #1859
Fix post octal bugs #1859
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good. I just wonder if the commented code should also be treated (or deleted).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @WalterKolczynski-NOAA !
Walter needs to merge develop into his hotfix branch for CI to work as this fix was just a tad behind. |
22a88d2
to
3f8ebce
Compare
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Automated global-workflow Testing Results:
|
Description
Yet more base bugs were found in post. To eliminate these once and for all,
fhr
is changed to have no leading zeros, and places where the zero-padded string is needed now usefhr3
.Resolves #1195
Type of change
Change characteristics
How has this been tested?
Checklist